Restrict ignore-mode-* directives
#131346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
jieyouxu
changed the title
ignore-mode-* directivesignore-mode-* directives
These are only valid for coverage test modes.
jieyouxu
force-pushed
the
prune-invalid-directives
branch
from
534bd72 to
64efbe2
Compare
|
Yeah, this seems reasonable. I implemented |
|
Thanks! @bors r+ rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 7, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131331 (Revert "warn_old_master_branch" check) - rust-lang#131344 (Avoid `&Lrc<T>` in various places) - rust-lang#131346 (Restrict `ignore-mode-*` directives) - rust-lang#131353 (Add documentation for `runtest::check_rustdoc_test_option` method) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 7, 2024
Rollup merge of rust-lang#131346 - jieyouxu:prune-invalid-directives, r=Zalathar Restrict `ignore-mode-*` directives This is only used by coverage test suites where the same sources get run under different coverage modes. Restrict `ignore-mode-<coverage_mode>` to only coverage modes.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 8, 2024
Simplify the compiletest directives for ignoring coverage-test modes Follow-up to rust-lang#131346. Given that these directives are now restricted to ignoring coverage-test modes only, we can drop the clunky `ignore-mode-*` naming convention, and just call them `ignore-coverage-map` and `ignore-coverage-run`. r? jieyouxu
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2024
Rollup merge of rust-lang#131400 - Zalathar:ignore-coverage, r=jieyouxu Simplify the compiletest directives for ignoring coverage-test modes Follow-up to rust-lang#131346. Given that these directives are now restricted to ignoring coverage-test modes only, we can drop the clunky `ignore-mode-*` naming convention, and just call them `ignore-coverage-map` and `ignore-coverage-run`. r? jieyouxu
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131331 (Revert "warn_old_master_branch" check) - rust-lang#131344 (Avoid `&Lrc<T>` in various places) - rust-lang#131346 (Restrict `ignore-mode-*` directives) - rust-lang#131353 (Add documentation for `runtest::check_rustdoc_test_option` method) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only used by coverage test suites where the same sources get run under different coverage modes. Restrict
ignore-mode-<coverage_mode>to only coverage modes.